[SDK] Fix Safe wallet WalletConnect connection on Berachain#8670
[SDK] Fix Safe wallet WalletConnect connection on Berachain#86700xFirekeeper merged 1 commit intomainfrom
Conversation
Add Berachain (80094) to the Safe supported chains whitelist and stop dropping the users requested chain when it is not in that list. This allows Safe wallets on Berachain to approve WalletConnect session proposals. Also remove duplicated dead-code Safe chain filtering in initProvider where the computed values were never consumed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
WalkthroughThis change adds Berachain mainnet (80094) to Safe wallet's supported chain list and simplifies chain request logic by converting Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 Comment |
size-limit report 📦
|
https://linear.app/thirdweb/issue/PRO-199/berachain-support-for-safe
Add Berachain (80094) to the Safe supported chains whitelist and stop dropping the users requested chain when it is not in that list. This allows Safe wallets on Berachain to approve WalletConnect session proposals. Also remove duplicated dead-code Safe chain filtering in initProvider where the computed values were never consumed.
PR-Codex overview
This PR focuses on simplifying the handling of
chainToRequestin thecontroller.tsfile by removing unnecessary checks and reassignments related tooptionalChains. It also adds a new chain ID for Berachain mainnet.Detailed summary
let chainToRequesttoconst chainToRequestfor immutability.chainToRequestwhenwalletIdis "global.safe".80094for Berachain mainnet to thechainsToRequestForSafearray.Summary by CodeRabbit
New Features
Bug Fixes