Implement permessage-deflate extension#357
Open
meetmangukiya wants to merge 1 commit intotheturtle32:masterfrom
Open
Implement permessage-deflate extension#357meetmangukiya wants to merge 1 commit intotheturtle32:masterfrom
meetmangukiya wants to merge 1 commit intotheturtle32:masterfrom
Conversation
|
I would want to see this load tested (very high load like 32k clients per server) if at all possible. About 12 months ago we tried to run perMessageDeflate using the ws module but it tanked the server side performance. We decided not to pursue pmd as we couldn't get the cpu resource usage under control with a very busy server. We run msgpack over binary frames which gives us typically about a 20-30% reduction in ota bandwidth with little or no client/server performance hit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might not be the best implementation..
Using
websocket-extensionsis gonna make it easier to hook any extension in here!I have tested it against a
permessage-deflateserver.