feat(PHP 8.1): support for ftp_raw
#693
Merged
+25
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silasjoisten
changed the title
ftp_raw on PHP 8.1ftp_raw
silasjoisten
force-pushed
the
feature/ftp_raw-php-8.1
branch
from
283f7b1 to
4a732ac
Compare
Collaborator
Author
|
@cedric-anne WDYT? |
Contributor
It could also be detected using a specific pattern in the |
Collaborator
Author
|
@cedric-anne aparently not. because again the version is pinned to a commit means it wont recognize the changes. the array already contains that very pattern |
Contributor
Unfortunately not. I'm not using this function anymore in the project in question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #653
@mvhirsch can you please test this?