Skip to content

Conversation

@gossi
Copy link
Contributor

@gossi gossi commented Feb 3, 2026

Impl for #236

I originally build this for Req. Then saw, there is Tesla. I followed their docs to build the client and make a request - I never used tesla before. I checked the response type from tesla and req and they are pretty equal for the response.

While I tested this with Req, this PR is completely untested - but I thought it's good enough to say hello :)

@jarlah
Copy link
Member

jarlah commented Feb 3, 2026

looks useful :) should be very easy to test it in a isolated manner outside a container configuration. Just start a container with the exunit macro and then construct and call the strategy ? then another test would be to create a special container, maybe an nginx container, that serves a specific html file or something. However it seems to always take a map in the match function. Is it a requirement as the strategy is now that response must be json ? Should it require that?

@gossi
Copy link
Contributor Author

gossi commented Feb 10, 2026

I did a test-case, verifying the default index.html file from nginx is up.

Is it a requirement as the strategy is now that response must be json ? Should it require that?

I don't think at all. You are free to pass headers and a matcher to adjust to your setting.

@gossi
Copy link
Contributor Author

gossi commented Feb 10, 2026

And I hit a timeout on CI. Quite ironic, it is a :socket_closed_remotely error, addressing that is the reason for this PR 😅

But apparently this is a layer lower - any idea for this?

@jarlah
Copy link
Member

jarlah commented Feb 10, 2026

being so random, i try to run them again. they told me nothing. It could be the engine, testcontainers calling the strategy, but meh .. i will think about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants