Skip to content

Quick hack for disabling fields based on configuration #3606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nickhurlburt wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Quick hack for disabling fields based on configuration #3606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...packages/hrm-form-definitions/form-definitions/as/v1/tabbedForms/ChildInformationTab.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"name": "firstName",
"label": "First Name",
"type": "input",
"isPII": true
"isPII": true,
"isDisabled": true
},
{
"name": "lastName",
Expand Down
1 change: 1 addition & 0 deletions lambdas/packages/hrm-form-definitions/src/formDefinition/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ type ItemBase = {
required?: { value: boolean; message: string } | boolean;
maxLength?: { value: number; message: string };
validate?: (data: any) => string | boolean;
isDisabled?: boolean;
} & IsPIIFlag;

type NonSaveable = {
Expand Down
2 changes: 1 addition & 1 deletion plugin-hrm-form/src/components/forms/hooks/useCreateFormFromDefinition.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ type UseFormFromDefinition = {
};
};

const alwaysEnabled = () => true;
const alwaysEnabled = (item: FormItemDefinition) => !((item as any).isDisabled ?? false);

const useCreateFormFromDefinition = ({
definition,
Expand Down
2 changes: 1 addition & 1 deletion plugin-hrm-form/src/components/forms/inputGenerator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
formItemDefinition,
parentsPath,
updateCallback,
isItemEnabled = () => true,
isItemEnabled = (item) => !((item as any).isDisabled ?? false),

Check failure on line 53 in plugin-hrm-form/src/components/forms/inputGenerator.tsx

View workflow job for this annotation

GitHub Actions / flex-ci / lint 

Replace `(item)` with `item`
initialValue,
customHandlers,
htmlElRef = null,
Expand Down
Loading