Skip to content

Correct signature size calculation #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
snie2012 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct signature size calculation #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/main/java/info/debatty/java/lsh/LSHMinHash.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public class LSHMinHash extends LSH {
*/
public LSHMinHash(final int s, final int b, final int n) {
super(s, b);
int signature_size = computeSignatureSize(s, n);
int signature_size = computeSignatureSize(s, b);
this.mh = new MinHash(signature_size, n);
}

Expand All @@ -66,7 +66,7 @@ public LSHMinHash(final int s, final int b, final int n) {
*/
public LSHMinHash(final int s, final int b, final int n, final long seed) {
super(s, b);
int signature_size = computeSignatureSize(s, n);
int signature_size = computeSignatureSize(s, b);
this.mh = new MinHash(signature_size, n, seed);
}

Copy link
Author

@snie2012 snie2012 Aug 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter should be changed to b as well.

Expand All @@ -92,7 +92,7 @@ public LSHMinHash(final int s, final int b, final int n, final long seed) {
private int computeSignatureSize(final int s, final int n) {

int r = (int) Math.ceil(Math.log(1.0 / s) / Math.log(THRESHOLD)) + 1;
return r * s;
return r * b;
}

/**
Expand Down