docs: fix nginx proxy_pass for "location /admin/" stanza
#438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As-is, the nginx sample configuration maps the location from the original URL (`/admin/`) to the location in the `pass_proxy` argument `http://localhost:3000/` (`/`) . Headplane does not have a route for `/`, so it returns a `404 Not Found` with this configuration. Headplane _does_ have a route for `/admin/`. By omitting the location portion of the `pass_proxy` argument, the location from the original URL is used (c.f. https://docs.nginx.com/nginx/admin-guide/web-server/reverse-proxy/#passing-a-request-to-a-proxied-server), serving up the correct content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As-is, the nginx sample configuration maps the location from the original URL (
/admin/) to the location in thepass_proxyargumenthttp://localhost:3000/(/) .Headplane does not have a route for
/, so it returns a404 Not Foundwith this configuration. Headplane does have a route for/admin/. By omitting the location portion of thepass_proxyargument, the location from the original URL is used (c.f. Passing a Request to a Proxied Server), serving up the correct content.