Open
Conversation
The 5-second node-level timeout fires before Electrum can complete a single request (10s timeout), causing FeerateEstimationUpdateTimeout on node start. Bump both FEE_RATE_CACHE_UPDATE_TIMEOUT_SECS and TX_BROADCAST_TIMEOUT_SECS from 5s to 15s. Upstream fixed this in lightningdevkit/ldk-node@40c4b09 (bumped to 10s). We use 15s for extra margin with slow Electrum servers.
spawn_background_processor_task is reserved for the single LDK background processor. The external scores sync was incorrectly using it, which caused a debug_assert panic when Node::start() later tried to spawn the actual background processor. Switch to spawn_cancellable_background_task which matches the pattern used by other periodic background tasks (RGS sync, peer reconnection, broadcast queue).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ben-kaufman
approved these changes
Mar 1, 2026
ovitrif
changed the title
coreyphillips
approved these changes
Mar 1, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEE_RATE_CACHE_UPDATE_TIMEOUT_SECSandTX_BROADCAST_TIMEOUT_SECSfrom 5s to 15s — the 5s node-level timeout fires before Electrum can complete a single request (10s timeout), causingFeerateEstimationUpdateTimeouton node startspawn_cancellable_background_taskfor external scores sync instead ofspawn_background_processor_task— the latter is reserved for the single LDK background processor and caused adebug_assertpanic whenNode::start()later tried to spawn itChanges
src/config.rssrc/scoring.rsspawn_cancellable_background_taskCargo.toml0.7.0-rc.29bindings/*bindgen.shCHANGELOG.mdPackage.swiftbindings/python/pyproject.tomlRelease
Integration
🤖 Generated with Claude Code