Skip to content

Allow Swift projects that use JavaScriptKit to compile on Windows #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kateinoigakukun merged 1 commit into from
Feb 24, 2026
+21 −0
Merged

Allow Swift projects that use JavaScriptKit to compile on Windows #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Plugins/BridgeJS/Sources/BridgeJSCommandPlugin/BridgeJSCommandPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
#if canImport(PackagePlugin)
#if os(Windows)
import WinSDK
#endif
import PackagePlugin
@preconcurrency import Foundation

Expand Down Expand Up @@ -180,7 +183,11 @@ extension Foundation.Process {
let signalSource = DispatchSource.makeSignalSource(signal: signalNo)
signalSource.setEventHandler { [self] in
signalSource.cancel()
#if os(Windows)
_ = TerminateProcess(processHandle, 0)
#else
kill(processIdentifier, signalNo)
#endif
}
signalSource.resume()
return signalSource
Expand Down
7 changes: 7 additions & 0 deletions Plugins/BridgeJS/Sources/TS2Swift/TS2Swift.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ import class Dispatch.DispatchSource
import SwiftParser
import SwiftSyntax

#if os(Windows)
import WinSDK
#endif
#if canImport(BridgeJSCore)
import BridgeJSCore
#endif
Expand Down Expand Up @@ -141,7 +144,11 @@ extension Foundation.Process {
let signalSource = DispatchSource.makeSignalSource(signal: signalNo)
signalSource.setEventHandler { [self] in
signalSource.cancel()
#if os(Windows)
_ = TerminateProcess(processHandle, 0)
#else
kill(processIdentifier, signalNo)
#endif
}
signalSource.resume()
return signalSource
Expand Down
7 changes: 7 additions & 0 deletions Plugins/PackageToJS/Sources/PackageToJS.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import Foundation

#if os(Windows)
import WinSDK
#endif
struct PackageToJS {
struct PackageOptions {
enum Platform: String, CaseIterable {
Expand Down Expand Up @@ -785,7 +788,11 @@ extension Foundation.Process {
let signalSource = DispatchSource.makeSignalSource(signal: signalNo)
signalSource.setEventHandler { [self] in
signalSource.cancel()
#if os(Windows)
_ = TerminateProcess(processHandle, 0)
#else
kill(processIdentifier, signalNo)
#endif
}
signalSource.resume()
return signalSource
Expand Down