Support sending and receiving trailers in HTTPExecutableRequest#882
Open
fabianfett wants to merge 4 commits intomainfrom
Open
Support sending and receiving trailers in HTTPExecutableRequest#882fabianfett wants to merge 4 commits intomainfrom
fabianfett wants to merge 4 commits intomainfrom
Conversation
fabianfett
force-pushed
the
ff-support-sending-trailers-internally
branch
from
f8c84b5 to
a723ff1
Compare
glbrntt
requested changes
Feb 5, 2026
Collaborator
glbrntt
left a comment
glbrntt
left a comment
There was a problem hiding this comment.
Could you add an end-to-end test as well?
| let channel = EmbeddedChannel(handlers: [handler], loop: eventLoop) | ||
| XCTAssertNoThrow(try channel.connect(to: .init(ipAddress: "127.0.0.1", port: 80)).wait()) | ||
|
|
||
| // non empty body is important to trigger this bug as we otherwise finish the request in a single flush |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be landed after #879.
This pr adds all the internal wiring in
HTTP1ClientChannelHandlerandHTTP2ClientRequestHandlerto send and receive HTTP trailers.