enable StrictConcurrency build setting#760
Open
weissi wants to merge 1 commit intoswift-server:mainfrom
Open
Conversation
Lukasa
requested changes
Aug 7, 2024
Collaborator
Lukasa
left a comment
Lukasa
left a comment
There was a problem hiding this comment.
This is currently incompatible with warnings-as-errors, so we need some CI tweaks to handle it.
Contributor
Author
Ah yeah, should I just tweak the CI? |
weissi
commented
Aug 7, 2024
|
|
||
| test: | ||
| <<: *common | ||
| command: /bin/bash -xcl "swift test --parallel -Xswiftc -warnings-as-errors --enable-test-discovery $${SANITIZER_ARG-} $${IMPORT_CHECK_ARG-}" |
Collaborator
|
That can work, though @FranzBusch is in the process of cutting over to a new CI scheme so we may want to hold off and tackle this slightly later. It's also not clear that AHC can easily do this without us sorting out NIO first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
so we know where there's work.