refactor: optimize polling and improve optimistic update stability#753
Open
SyedaAnshrahGillani wants to merge 1 commit intosupermemoryai:mainfrom
Conversation
- Increased subscription status refetch interval from 5s to 60s to reduce unnecessary network load. - Improved 'useDeleteDocument' optimistic update to handle both standard and infinite query data structures, preventing potential runtime errors and ensuring UI consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Polling Optimization:
fetchSubscriptionStatus from 5 seconds to 60 seconds.
seconds was unnecessarily aggressive, leading to excessive network
traffic and load on the billing service (Autumn). Increasing this to 1
minute significantly improves client performance and reduces server
load without impacting user experience.
Optimistic Update Stability:
useDeleteDocument mutation.
used by infinite queries. If the documents-with-memories query was used
as a standard query elsewhere in the app, the optimistic update would
have failed or caused runtime errors. The new implementation safely
handles both standard query (flat documents array) and infinite query
(paged documents) structures, ensuring UI consistency and robustness.
Code Quality & Linting:
Biome's linting rules, replacing any with safer unknown and
Record<string, unknown> types.
biome check --write.
Verification
synchronized.
regressions.
(Bun) are correctly utilized.