Open
Conversation
Contributor
CLI Documentation Generator
📚 Commands documented
|
Contributor
Preview Deployment
Commit: |
Contributor
Lighthouse Results
|
Contributor
E2E Test Results✅ Tests success Ran against: https://pr-144-superfly-sprites-docs.fly.dev |
Collaborator
|
@kylemclaren @igor-ladkin Looks like GHA immediately commits CLI updates to the PR branch -- wouldn't it make more sense to put these in a separate PR? Located in The rest of the PR LGTM :) |
Author
|
@kcmartin oh yeah, for sure. We should include CLI changes here, at least it was not intended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you navigate b/w different docs pages, our header is flickering and page flashes sometimes because it's plain old browser navigation and it requires repaint. Astro supports client router that makes it feel like we are in smooth SPA by utilizing page transitions api. Also moved glass morphism hook into CSS since we always have theme data attribute.