feat(deploy): warn when volume changes will replace machine#4726
Merged
feat(deploy): warn when volume changes will replace machine#4726
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the deploy command to warn users when volume configuration changes will cause machines to be replaced, requiring explicit confirmation before proceeding. Previously, the system would immediately fail when detecting volume misconfigurations; now it provides a warning with actionable guidance and allows users to confirm their intent.
Changes:
- Removed automatic warning from
launchInputForUpdatewhen mounts section is removed from fly.toml - Added interactive prompt in
validateVolumeConfigto warn users and request confirmation before detaching volumes - Enhanced
validateVolumeConfigto accept context parameter for proper prompt handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| internal/command/deploy/machines_launchinput.go | Removed inline warning when mount section is removed, as validation now happens earlier in the flow |
| internal/command/deploy/machines.go | Added interactive prompt with confirmation when machine has volume but config doesn't specify one, includes proper error handling for non-interactive mode |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Added warning & confirmation when deploy will replace machines due to volume configuration changes.
Documentation