Added tests for CI and fixed yml file for SwiftLint#20
Open
Anish0999 wants to merge 15 commits intosuperarts:masterfrom
Open
Added tests for CI and fixed yml file for SwiftLint#20Anish0999 wants to merge 15 commits intosuperarts:masterfrom
Anish0999 wants to merge 15 commits intosuperarts:masterfrom
Conversation
superarts
requested changes
Jan 6, 2024
Owner
superarts
left a comment
superarts
left a comment
There was a problem hiding this comment.
@Anish0999 I have reviewed one file of your PR. However, I'm going to ask you to look at your PR again, read our slack conversation, and figure out the rest of your problems by yourself.
It is OK for me to direct you through the tasks, but I don't want to keep repeating myself.
| jobs: | ||
| test: | ||
| name: Run Swift Tests | ||
| runs-on: ubuntu-latest |
Owner
There was a problem hiding this comment.
This is an interesting approach. Users of this tool should be using macOS, but making the tool cross-platform may have some value?
| @@ -0,0 +1,24 @@ | |||
| name: Swift | |||
Owner
There was a problem hiding this comment.
Suggested change
| name: Swift | |
| name: Swift unit test |
Owner
There was a problem hiding this comment.
Please rename to swift-unit-test.yml
.github/workflows/swift.yml
Outdated
|
|
||
| steps: | ||
| - name: Check out code | ||
| uses: actions/checkout@v2 |
Owner
There was a problem hiding this comment.
Why not using the latest version? I think it's v4 now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request added tests for CI and fixed the yml file to pull request for SwiftLint
Issues Resolved
Changes Made
Checklist
Additional Comments
N/A