fix: parser treats 'atomic' in identifiers as BEGIN ATOMIC keyword #4747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parser incorrectly treats
atomicsubstring in identifiers asBEGIN ATOMICkeyword, causing migration failures.Problem
Migrations with table/column names containing
atomicfail with:ERROR: cannot insert multiple commands into a prepared statement (SQLSTATE 42601)
Example:
Root cause: Parser matches atomic in identifiers as the BEGIN ATOMIC keyword, enters a state where semicolons are ignored, and merges multiple statements into one.
Solution
Added word boundary check: ATOMIC only recognized as keyword when preceded by whitespace.
This prevents false matches in identifiers while preserving correct BEGIN ATOMIC function body handling.
Related