fix(db): execute seed sql for modified seed files #4671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a seed file is modified, the cli was only updating the hash in the seed_files table but skipping the actual sql execution. this happened because ExecBatchWithCache only queued sql statements when Dirty was false, but modified seeds have Dirty set to true.
|
@7ttp Could we get this landed soon? |
Contributor
Author
Contributor
|
This is intentional because most seed scripts are not idempotent. My suggestion would be to add a new seed file. Wdyt? |
@sweatybridge The CLI prompts the user about updated seed files and then updates the hash for the file references stored in the database in supabse_migrations.seed_files. This seems to imply the files are run and it also informs the user prior to running them, so it's confusing if they aren't run. Shouldn't it be the user's responsibility not to update a seed file if it's not idempotent? If I have to make new seed files then that feels no different to migrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when running
supabase db push --include-seed, modified seed files were detected and their hashes updated, but the actual seed sql was not executed. this happened becauseExecBatchWithCacheonly queued sql statements whenDirtywas false, but modified seeds haveDirtyset to true.closes #4670