Allow change vocabs for processor that take vocabs #778
+254
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhnwu3
requested changes
Jan 11, 2026
Collaborator
jhnwu3
left a comment
jhnwu3
left a comment
There was a problem hiding this comment.
Can we add a def add(self, vocabularies : set[str) operation as well? Just in case?
Understandably, no model can do this (yet). But, I can imagine a future where models simply add another row to the vocabulary embeddings within a model and do some type of continual learning/finetuning in the future as this is an active area of research in many conferences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor: Yongda Fan (yongdaf2@illinois.edu)
Contribution Type: Processor
Description
Add
retainandremovemethod to modify thecode_vocabin the processors. This should facilitate the PyHealth agent to select or remove particular code it deteremines to be useful or not useful.