Fix: Prevent zero-division in Cp calculation for zero free-stream velocity #2666
+15
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Pressure Coefficient (
Cp) calculation currently divides byReferenceDynamicPressurewithout checking if it is zero.This causes
NaNvalues or crashes when:Solution
Added a safety check for
GetReferenceDynamicPressure()in:CFlowCompOutput.cpp(Compressible)CFlowIncOutput.cpp(Incompressible)CNEMOCompOutput.cpp(NEMO / Hypersonic)If the dynamic pressure is effectively zero (
abs < 1e-10), the Cp output defaults to0.0instead of performing the division.