feat: Add the ability to parse markdown and replace tags asynchronously, and fetch the missing users and channels.#131
Open
Dadadah wants to merge 8 commits intostoatchat:mainfrom
Open
Conversation
chrishultin
approved these changes
Feb 22, 2026
Contributor
chrishultin
left a comment
chrishultin
left a comment
There was a problem hiding this comment.
I feel like it could be optimized a tiny bit by waiting for both userReplacements and channelReplacements in parallel, instead of in series, but I think that's fine for now.
Member
Author
|
I've refactored the code a bit to add deduplication, and to wait for all replacements in parallel instead of series. |
chrishultin
requested changes
Feb 28, 2026
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Dadadah
force-pushed
the
feat/asyncmessageparse
branch
from
ddbbbcb to
89ed246
Compare
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
Signed-off-by: Christopher Hultin <chris.hultin@gmail.com>
chrishultin
approved these changes
Feb 28, 2026
This commit was made without the use of generative AI. Signed-off-by: Jacob Schlecht <dadadah@echoha.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to fetch missing users and channels while parsing markdown asynchronously. This is particularly important for push notifications, as we do not have access to the full client when receiving push notifications.
This PR also updates the
ulidpackage to v3, which is required in order to get the ulid package to work in service workers. This is due to service workers not having access to the secure crypto library, which ulid v3 no longer depends on.