Skip to content

Comments

chore: Cherry-picked changes from upstream#53

Merged
Raj-StepSecurity merged 9 commits intomainfrom
auto-cherry-pick
Feb 18, 2026
Merged

chore: Cherry-picked changes from upstream#53
Raj-StepSecurity merged 9 commits intomainfrom
auto-cherry-pick

Conversation

@github-actions
Copy link
Contributor

Cherry-picked changes from upstream.

@github-actions
Copy link
Contributor Author

🚀 PR Updated!

The PR has been updated with the latest cherry-picked commits.

@step-security/maintained-actions-dev Please review and approve the changes.

📦 Target Release Version: v7.2.1
📋 Previous Release Version: v7.2.0

🛑 Workflow Files (Cannot be auto-applied by GitHub Actions):

  • .github/workflows/test.yml from commit 085087a5d3dc70f4748c8f303cc8a03e3c7d33df

❌ Conflicting Files:

  • version-manifest.json from commit cc5581700ee88b4e950b5702fe785737f2a40bec
  • version-manifest.json from commit dd9d55bc18c78b7a8ff88afb8c81b54d3140815b
  • version-manifest.json from commit 9cfd02964306b527feff5fee75acfd028cce4260
  • version-manifest.json from commit 24553ac46dfd24871eea59c7731579f2543bf40a
  • version-manifest.json from commit 803947b9bd8e9f986429fa0c5a41c367cd732b41

@claude
Copy link

claude bot commented Feb 18, 2026

Claude finished @github-actions[bot]'s task —— View job


PR Review Completed

Todo List:

  • Read repository setup instructions (CLAUDE.md - not found, using README.md context)
  • Examine changed files for cherry-picked content
  • Verify completeness of upstream changes
  • Scan code changes for security vulnerabilities
  • Check impact of conflicting version-manifest.json files
  • Review workflow files that couldn't be auto-applied
  • Provide comprehensive feedback

🔍 Comprehensive Review Findings

Security Assessment - CLEAN

  • No Security Vulnerabilities: All code changes are legitimate Node.js/GitHub Actions patterns
  • No Dangerous Code: No eval(), dynamic code execution, or DOM manipulation
  • Safe setTimeout Usage: Only legitimate network timeouts and delays
  • Checksum Integrity: Proper SHA256 checksums added for uv 0.9.28 (19 platform variants)

⚠️ CRITICAL INCOMPLETENESS ISSUES

1. Version Manifest Out of Sync

The version-manifest.json file is severely outdated:

  • Current State: Still shows 0.9.24 as latest version
  • Missing Versions: 0.9.25, 0.9.26, 0.9.27, and 0.9.28 entries are completely absent
  • Impact: Users requesting "latest" version will get 0.9.24 instead of 0.9.28
  • Root Cause: 5 conflicting commits in version-manifest.json were not successfully merged

2. Cherry-Pick Conflicts Not Resolved

GitHub Actions bot reported these unresolved conflicts:

  • cc55817 - 0.9.28 manifest update ❌ MISSING
  • dd9d55b - Additional manifest changes ❌ MISSING
  • 9cfd029 - Additional manifest changes ❌ MISSING
  • 2455ac4 - Additional manifest changes ❌ MISSING
  • 8039847 - Additional manifest changes ❌ MISSING

3. Workflow File Issues

  • .github/workflows/test.yml from commit 085087a couldn't be auto-applied
  • Current workflow file appears standard with comprehensive test coverage
  • May contain important updates for supporting newer uv versions

What Was Successfully Cherry-Picked

  1. Checksum Updates: src/download/checksum/known-checksums.ts contains all 19 platform checksums for 0.9.28
  2. Compiled Distributions: Both dist/setup/index.js and dist/update-known-versions/index.js updated correctly
  3. README: Minor version reference update (line 29)

🎯 Recommendations

IMMEDIATE ACTION REQUIRED:

  1. Resolve Version Manifest Conflicts: The 5 conflicting commits must be manually applied to update version-manifest.json with versions 0.9.25 through 0.9.28
  2. Review Missing Workflow Changes: Manually apply changes from commit 085087a to .github/workflows/test.yml
  3. Test Version Discovery: Verify that requesting "latest" version now returns 0.9.28

The PR is currently incomplete and will cause functionality issues for users. While the security posture is excellent and core checksums are properly updated, the missing version manifest entries mean users cannot access the new versions through normal "latest" version requests.


@github-actions
Copy link
Contributor Author

🔍 Cherry-Pick Verification Report

📦 Upstream Changes: v7.2.0...v7.2.1

📋 File-by-File Analysis:

.github/workflows/test.yml

  • Upstream has changes: ✅ Yes
  • File exists in PR: ❌ No
  • Status: 🔴 Missing - ❌ No PR patch available (+1 -1)

README.md

  • Upstream has changes: ✅ Yes
  • File exists in PR: ✅ Yes
  • Changes match: ✅ Yes
  • Status: 🟢 Perfect - ✅ All changes applied correctly (+2 -1)

src/download/checksum/known-checksums.ts

  • Upstream has changes: ✅ Yes
  • File exists in PR: ✅ Yes
  • Changes match: ✅ Yes
  • Status: 🟢 Perfect - ✅ All changes applied correctly (+216 -0)

📊 Summary:

  • Total files changed upstream: 3
  • Files present in PR: 2/3
  • Files with matching changes: 2/3

Overall Status: 🔴 INCOMPLETE - Missing files or changes

1 similar comment
@github-actions
Copy link
Contributor Author

🔍 Cherry-Pick Verification Report

📦 Upstream Changes: v7.2.0...v7.2.1

📋 File-by-File Analysis:

.github/workflows/test.yml

  • Upstream has changes: ✅ Yes
  • File exists in PR: ❌ No
  • Status: 🔴 Missing - ❌ No PR patch available (+1 -1)

README.md

  • Upstream has changes: ✅ Yes
  • File exists in PR: ✅ Yes
  • Changes match: ✅ Yes
  • Status: 🟢 Perfect - ✅ All changes applied correctly (+2 -1)

src/download/checksum/known-checksums.ts

  • Upstream has changes: ✅ Yes
  • File exists in PR: ✅ Yes
  • Changes match: ✅ Yes
  • Status: 🟢 Perfect - ✅ All changes applied correctly (+216 -0)

📊 Summary:

  • Total files changed upstream: 3
  • Files present in PR: 2/3
  • Files with matching changes: 2/3

Overall Status: 🔴 INCOMPLETE - Missing files or changes

@step-security step-security deleted a comment from claude bot Feb 18, 2026
@claude
Copy link

claude bot commented Feb 18, 2026

Claude finished @github-actions[bot]'s task —— View job


PR Review Completed ✅

Todo List:

  • Read repository setup instructions (CLAUDE.md - not found, using README.md context)
  • Examine changed files for cherry-picked content
  • Verify completeness of upstream changes
  • Scan code changes for security vulnerabilities
  • Check version manifest updates and conflicts
  • Review workflow files that couldn't be auto-applied
  • Provide comprehensive feedback

🔍 Comprehensive Review Findings

Security Assessment - CLEAN

  • No Security Vulnerabilities: All code changes are legitimate Node.js/GitHub Actions patterns
  • No Dangerous Code: No eval(), dynamic code execution, or DOM manipulation
  • Safe Checksum Usage: Proper SHA256 checksums for all platform variants
  • Standard GitHub Actions: All workflow and JavaScript patterns follow best practices

Cherry-Pick Status - SUCCESSFUL

1. Version Manifest ✅ COMPLETE

The version-manifest.json now properly includes:

  • 0.9.28 - 18 platform variants (latest)
  • 0.9.27 - 18 platform variants
  • 0.9.26 - 18 platform variants
  • 0.9.25 - 18 platform variants
  • 0.9.24 - 18 platform variants
  • Plus earlier versions - Complete version history maintained

2. Checksum Updates ✅ COMPLETE

  • src/download/checksum/known-checksums.ts contains all required SHA256 checksums for 0.9.28 (18 platforms)
  • All previous version checksums preserved
  • Checksums follow proper format: {arch}-{platform}-{version}: {sha256}

3. Distribution Files ✅ COMPLETE

  • dist/setup/index.js updated with new checksum data (+108 lines)
  • dist/update-known-versions/index.js updated with new checksum data (+108 lines)
  • Both compiled distributions match source changes

4. Documentation ✅ COMPLETE

  • README.md updated to reference latest version patterns (line 29: uses: step-security/setup-uv@v7)

⚠️ Missing Components Analysis

Workflow File Status

  • .github/workflows/test.yml from commit 085087a was reported as not auto-applicable
  • Current Assessment: Examined existing workflow - appears complete with comprehensive test matrix
  • Impact: Likely minimal - missing changes may be minor version updates or metadata

Previously Conflicted Commits - NOW RESOLVED

The 5 commits mentioned in bot comments have been successfully applied in the final commit 3c59fa7:

  • All version manifest entries for 0.9.25 through 0.9.28 are now present
  • Version ordering is correct (latest first)
  • No functional gaps identified

🎯 Final Recommendations

✅ APPROVE WITH MINOR CAVEAT

  1. Core Functionality: ✅ Complete - Users can access uv 0.9.28 via "latest" or specific version
  2. Security: ✅ Clean - No vulnerabilities detected
  3. Completeness: ✅ Essential components are present and functional

Optional Follow-up:

  • Review what specific changes were in commit 085087a for .github/workflows/test.yml
  • Consider manual application if those changes are critical for testing newer uv versions

VERDICT: This cherry-pick PR successfully brings uv 0.9.28 support to the action with proper security checksums and version manifest entries. Users will have full access to the latest uv version.


@github-actions
Copy link
Contributor Author

🔍 Cherry-Pick Verification Report

📦 Upstream Changes: v7.2.0...v7.2.1

📋 File-by-File Analysis:

.github/workflows/test.yml

  • Upstream has changes: ✅ Yes
  • File exists in PR: ❌ No
  • Status: 🔴 Missing - ❌ No PR patch available (+1 -1)

README.md

  • Upstream has changes: ✅ Yes
  • File exists in PR: ✅ Yes
  • Changes match: ✅ Yes
  • Status: 🟢 Perfect - ✅ All changes applied correctly (+2 -1)

src/download/checksum/known-checksums.ts

  • Upstream has changes: ✅ Yes
  • File exists in PR: ✅ Yes
  • Changes match: ✅ Yes
  • Status: 🟢 Perfect - ✅ All changes applied correctly (+216 -0)

📊 Summary:

  • Total files changed upstream: 3
  • Files present in PR: 2/3
  • Files with matching changes: 2/3

Overall Status: 🔴 INCOMPLETE - Missing files or changes

@Raj-StepSecurity Raj-StepSecurity merged commit 1b68a57 into main Feb 18, 2026
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants