build: Pass CMAKE_INSTALL_LIBDIR to qm_install_package subprocess #14
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes find_package() failures on Fedora (lib64) and Debian multiarch systems by passing CMAKE_INSTALL_LIBDIR to the subprocess, ensuring the package installs to the same location where the parent expects to find it.
Collaborator
|
Would you mind adding some comments in this cmake file? |
wangwenx190
requested changes
Jan 30, 2026
Collaborator
wangwenx190
left a comment
wangwenx190
left a comment
There was a problem hiding this comment.
Yeah I also think it's worthy to leave some comments in the cmake file, it's hard to understand why do we need this line without any context.
| set(${FUNC_RESULT_PATH} ${_install_cmake_dir} PARENT_SCOPE) | ||
| endif() | ||
| endfunction() No newline at end of file | ||
| endfunction() |
Collaborator
There was a problem hiding this comment.
The encoding or line ending seems to be changed, better to restore this change
| execute_process( | ||
| COMMAND ${CMAKE_COMMAND} -S ${_src_dir} -B ${_build_dir} | ||
| ${_extra_args} ${_build_type} | ||
| "-DCMAKE_INSTALL_LIBDIR=${CMAKE_INSTALL_LIBDIR}" |
Collaborator
There was a problem hiding this comment.
is this some sort of cmake's own bug?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes find_package() failures on Fedora (lib64) and Debian multiarch systems by passing CMAKE_INSTALL_LIBDIR to the subprocess, ensuring the package installs to the same location where the parent expects to find it.