feat: add stats/base/ndarray/sstdevtk
#9917
Open
+992
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
Statistics
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
requested changes
Jan 28, 2026
Member
Planeshifter
left a comment
Planeshifter
left a comment
There was a problem hiding this comment.
Thanks for opening a PR!
Comment on lines
50
to
84
| function createBenchmark(len) { | ||
| var correction; | ||
| var xbuf; | ||
| var x; | ||
|
|
||
| xbuf = uniform(len, -10.0, 10.0, options); | ||
| x = new ndarray(options.dtype, xbuf, [len], [1], 0, 'row-major'); | ||
| correction = scalar2ndarray(1.0, options); | ||
|
|
||
| return benchmark; | ||
|
|
||
| /** | ||
| * Benchmark function. | ||
| * | ||
| * @private | ||
| * @param {Benchmark} b - benchmark instance | ||
| */ | ||
| function benchmark(b) { | ||
| var v; | ||
| var i; | ||
|
|
||
| b.tic(); | ||
| for (i = 0; i < b.iterations; i++) { | ||
| v = sstdevtk([x, correction]); | ||
| if (isnanf(v)) { | ||
| b.fail('should not return NaN'); | ||
| } | ||
| } | ||
| b.toc(); | ||
| if (isnanf(v)) { | ||
| b.fail('should not return NaN'); | ||
| } | ||
| b.pass('benchmark finished'); | ||
| b.end(); | ||
| } |
Member
There was a problem hiding this comment.
The benchmark file is missing spaces inside parentheses throughout — stdlib style requires spaces after ( and before ) in function calls and declarations (e.g., createBenchmark( len ) not createBenchmark(len)). Compare with a package like @stdlib/stats/base/ndarray/sstdev/benchmark/benchmark.js which follows the correct spacing.
Comment on lines
105
to
108
| for (i = min; i <= max; i++) { | ||
| len = pow(10, i); | ||
| f = createBenchmark(len); | ||
| bench(format('%s:len=%d', pkg, len), f); |
Member
There was a problem hiding this comment.
Same spacing issue in main() — the for loop and function calls here also need spaces inside parentheses.
Suggested change
| for (i = min; i <= max; i++) { | |
| len = pow(10, i); | |
| f = createBenchmark(len); | |
| bench(format('%s:len=%d', pkg, len), f); | |
| for ( i = min; i <= max; i++ ) { | |
| len = pow( 10, i ); | |
| f = createBenchmark( len ); | |
| bench( format( '%s:len=%d', pkg, len ), f ); |
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
Erennn7
force-pushed
the
feat/stats-base-ndarray-sstdevtk
branch
from
ede1d64 to
90544af
Compare
Contributor
Author
|
Hey, @Planeshifter thanks for catching that! Fixed the spacing throughout the benchmark file. Should be all good now . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:
Description
This pull request:
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers