-
Notifications
You must be signed in to change notification settings - Fork 24
Convert EMBEDDING_ related codes and V1 codes used in EGW to V2
#2364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📉 Unit Test Coverage Delta vs Main Branch
|
Unit Test Coverage Report
|
📉 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Integration Test Coverage Report (dse69-it)
|
📉 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Integration Test Coverage Report (hcd-it)
|
...est/java/io/stargate/sgv2/jsonapi/service/embedding/operation/OpenAiEmbeddingClientTest.java
Outdated
Show resolved
Hide resolved
EMBEDDING_ in ErrorCodeV1 to V2EMBEDDING_ related codes and V1 codes used in EGW to V2
src/main/java/io/stargate/sgv2/jsonapi/service/reranking/operation/NvidiaRerankingProvider.java
Outdated
Show resolved
Hide resolved
tatu-at-datastax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one question here (and in matching EGW PR): looks like VECTORIZE_SERVICE_TYPE_UNAVAILABLE was mapped to EMBEDDING_GATEWAY_NOT_AVAILABLE. Is this intentional? Existing fail sounds like one of providers had an issue, not EGW itself -- so should it map to EMBEDDING_PROVIDER_UNAVAILABLE instead (or EMBEDDING_PROVIDER_SERVER_ERROR or EMBEDDING_GATEWAY_PROCESSING_ERROR)?
tatu-at-datastax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Convert all the
EMBEDDING_related codes and the V1 codes used in EGW to V2.Have another PR https://github.com/riptano/embedding-gateway/pull/154 in EGW to fit this change
Which issue(s) this PR fixes:
Fixes #2285
Checklist