Skip to content

Conversation

@Hazel-Datastax
Copy link
Contributor

@Hazel-Datastax Hazel-Datastax commented Jan 27, 2026

What this PR does:
Convert all the EMBEDDING_ related codes and the V1 codes used in EGW to V2.
Have another PR https://github.com/riptano/embedding-gateway/pull/154 in EGW to fit this change

Which issue(s) this PR fixes:
Fixes #2285

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

📉 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 50.47%
This PR 50.33%
Delta 🔴 -0.14%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Unit Test Coverage Report

Overall Project 50.33% -0.56% 🍏
Files changed 36.74%

File Coverage
EmbeddingProviderException.java 100% 🍏
EmbeddingProviderResponseValidation.java 90.11% 🍏
RerankingEGWClient.java 85.93% 🍏
JsonApiException.java 80.42% 🍏
ErrorCodeV1.java 70.59% 🍏
EmbeddingProvider.java 70.38% -12.8% 🍏
EmbeddingGatewayClient.java 61.9% -6.23%
DataVectorizer.java 50.63% -12.77%
EmbeddingProviderFactory.java 20.62% -27.58%
ValidateCredentials.java 0% -3.95%
PropertyBasedServiceConfigStore.java 0% -17.89%
FrameworkExceptionMapper.java 0% 🍏
AwsBedrockEmbeddingProvider.java 0% -46.71%
EmbeddingDeferredAction.java 0% -12.61%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

📉 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 70.87%
This PR 70.77%
Delta 🔴 -0.10%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 70.77% -0.74% 🍏
Files changed 16.29%

File Coverage
EmbeddingProviderException.java 88% -12% 🍏
FrameworkExceptionMapper.java 87.71% 🍏
PropertyBasedServiceConfigStore.java 78.05% -17.89%
JsonApiException.java 68.78% 🍏
ErrorCodeV1.java 63.73% 🍏
EmbeddingDeferredAction.java 57.66% -12.61%
EmbeddingProviderFactory.java 57.47% -20.88%
EmbeddingProvider.java 41.47% -33.65%
DataVectorizer.java 39.57% -19.16%
EmbeddingProviderResponseValidation.java 25.27% -34.07%
ValidateCredentials.java 7.89% -3.95%
RerankingEGWClient.java 0% -3.7%
EmbeddingGatewayClient.java 0% -10.99%
AwsBedrockEmbeddingProvider.java 0% -46.71%

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.60%
This PR 72.50%
Delta 🔴 -0.10%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Jan 27, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 72.5% -0.74% 🍏
Files changed 16.29%

File Coverage
EmbeddingProviderException.java 88% -12% 🍏
FrameworkExceptionMapper.java 87.71% 🍏
PropertyBasedServiceConfigStore.java 78.05% -17.89%
JsonApiException.java 68.78% 🍏
ErrorCodeV1.java 63.73% 🍏
EmbeddingDeferredAction.java 57.66% -12.61%
EmbeddingProviderFactory.java 57.47% -20.88%
EmbeddingProvider.java 41.47% -33.65%
DataVectorizer.java 39.57% -19.16%
EmbeddingProviderResponseValidation.java 25.27% -34.07%
ValidateCredentials.java 7.89% -3.95%
RerankingEGWClient.java 0% -3.7%
EmbeddingGatewayClient.java 0% -10.99%
AwsBedrockEmbeddingProvider.java 0% -46.71%

@Hazel-Datastax Hazel-Datastax changed the title Convert EMBEDDING_ in ErrorCodeV1 to V2 Convert EMBEDDING_ related codes and V1 codes used in EGW to V2 Feb 2, 2026
@Hazel-Datastax Hazel-Datastax marked this pull request as ready for review February 2, 2026 19:11
@Hazel-Datastax Hazel-Datastax requested a review from a team as a code owner February 2, 2026 19:11
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one question here (and in matching EGW PR): looks like VECTORIZE_SERVICE_TYPE_UNAVAILABLE was mapped to EMBEDDING_GATEWAY_NOT_AVAILABLE. Is this intentional? Existing fail sounds like one of providers had an issue, not EGW itself -- so should it map to EMBEDDING_PROVIDER_UNAVAILABLE instead (or EMBEDDING_PROVIDER_SERVER_ERROR or EMBEDDING_GATEWAY_PROCESSING_ERROR)?

Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hazel-Datastax Hazel-Datastax merged commit ed56918 into main Feb 3, 2026
4 checks passed
@Hazel-Datastax Hazel-Datastax deleted the hazel/convert-embedding-error-code branch February 3, 2026 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Convert ErrorCodeV1 error codes (~40 remaining) to new ("V2") variant

3 participants