-
Notifications
You must be signed in to change notification settings - Fork 4
Mine Bitcoin blocks using a dedicated wallet #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Mine Bitcoin blocks using a dedicated wallet #32
Conversation
cf428f5 to
e76b18f
Compare
|
Ran this over weekend, seems to work just fine! Taking this PR out of draft. A new snapshot will be needed after we agree on the changes included in this PR. |
README.md
Outdated
| ‣ BTC Address: miBGjFEQveJSbzFwB9XJ9a4GmkY3Unmb7b | ||
| ‣ Stacks Address: STEJYWJ2Y7E72AF9JMRWZWNR11ADBJBHD45P7D7K | ||
| ‣ WIF: cU5McyYQu1VJw6tzekyAJd1Jm9NVtjkPhrcbyVm8LgGdiW1Htrf4 | ||
| ‣ Private Key: a549000d3c6da1037c2ae8201400d1abb2cc1230f9e415f9000af94d1ffd7ee601 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to remove the mnemonic keys here? techinically it's not required, but i'm curious why it's removed (same question for the other addresses)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the README was outdated, I just updated it to match docker-compose.yml. At some point we lost track of the mnemonics, so they are currently unknown. We can also create new wallets only for the Stacks and Bitcoin miners and list all the details in both README and docker-compose.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to have the mnemonics as well tho 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 02acc7a. Great catch!
wileyj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, only a question about the readme
e76b18f to
543a682
Compare
This PR changes Hacknet’s mining script so it only funds the Stacks miners at startup while continuing to mine Bitcoin blocks using a dedicated Bitcoin miner address. It also updates the README accounts.