Add upstream Identity Provider types and interfaces #3260
Merged
+763
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce foundational types for communicating with upstream Identity Providers (e.g. Google) in the authorization server: - Provider interface: abstracts IDP operations (authorization URL generation, code exchange, token refresh, userinfo) - IDTokenNonceValidator: optional interface for OIDC nonce validation to prevent replay attacks - UserInfoSubjectValidator: optional interface for OIDC Section 5.3.4 subject validation to prevent impersonation - Tokens: represents access/refresh/ID tokens from upstream IDP - IDTokenClaims: parsed OIDC ID token claims including azp for multi-audience token validation - Config: upstream IDP connection configuration with redirect URI validation These types are implemented by OIDCProvider in the full authorization server and used for token exchange flows where the auth server acts as an OAuth client to upstream IDPs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3260 +/- ##
==========================================
+ Coverage 63.54% 63.66% +0.12%
==========================================
Files 355 358 +3
Lines 35058 35199 +141
==========================================
+ Hits 22279 22411 +132
- Misses 10978 10984 +6
- Partials 1801 1804 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmjb
reviewed
Jan 12, 2026
dmjb
previously approved these changes
Jan 12, 2026
In a future commit when we actually make use of the itnerface, we'll rather use one from toolhive's networking package
github-actions
bot
added
size/L
jhrozek
commented
Jan 12, 2026
JAORMX
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce foundational types for communicating with upstream Identity Providers (e.g. Google) in the authorization server:
These types are implemented by OIDCProvider in the full authorization server and used for token exchange flows where the auth server acts as an OAuth client to upstream IDPs.