fix: server yaml output of userdata field displayed as bytearray instead of base64 #954
Conversation
Merging this branch will decrease overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
| // convertServerForYAML creates a map with UserData as base64 string for YAML output | ||
| func convertServerForYAML(server *iaas.Server) map[string]interface{} { | ||
| if server == nil { | ||
| return nil | ||
| } | ||
|
|
||
| // Marshal to JSON first to get the correct format for UserData | ||
| jsonData, err := json.Marshal(server) | ||
| if err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| var serverMap map[string]interface{} | ||
| if err := json.Unmarshal(jsonData, &serverMap); err != nil { | ||
| return nil | ||
| } | ||
|
|
||
| return serverMap | ||
| } | ||
|
|
There was a problem hiding this comment.
I think it would be better to move this into the utils package and make the function more generic. So that it's not specific for iaas.Server and can be used by other types as well. In $ stackit server list -o yaml, we have the same issue and with a more generic utils function, we could reuse it there
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Description
Jira: https://jira.schwarz/browse/STACKITCLI-219
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)