fix: stackit beta network-area commands - add nil pointer checks and tests for the outputResult functions #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

marceljk merged 3 commits into main from fix/add-nil-pointer-checks-in-network-area-commands-and-add-tests

Feb 21, 2025

Contributor

marceljk commented Feb 19, 2025

add nil pointer checks
add tests for the outputResult functions within the network-area commands


          - add nil pointer checks

c30fd8f

- add tests for the outputResult functions within the network-area commands

marceljk requested review from Fyusel, bahkauv70 and rubenhoenle as code owners

February 19, 2025 16:19


          fix: consistent else if-clause for labels

f709f08

rubenhoenle reviewed

View reviewed changes

internal/cmd/beta/network-area/list/list_test.go Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/beta/network-area/network-range/list/list_test.go Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/beta/network-area/route/list/list_test.go Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/beta/network-area/route/update/update_test.go Show resolved Hide resolved

rubenhoenle reviewed

View reviewed changes

internal/cmd/beta/network-area/update/update_test.go Show resolved Hide resolved

rubenhoenle previously approved these changes

View reviewed changes


          implement review feedback

8fe07a3

marceljk dismissed rubenhoenle’s stale review via

8fe07a3

February 21, 2025 07:50

marceljk requested a review from rubenhoenle

February 21, 2025 07:52

rubenhoenle approved these changes

View reviewed changes

marceljk merged commit bb61f05 into main

3 checks passed

marceljk deleted the fix/add-nil-pointer-checks-in-network-area-commands-and-add-tests branch

February 21, 2025 14:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet