-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Versioning for airflow-operator #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tests/templates/kuttl/mount-dags-gitsync/30-install-airflow-cluster.yaml.j2
Show resolved
Hide resolved
Techassi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Also let me know if I should take a look at the documentation as well.
Also, I can review (and eventually approve) the operator-rs PR before we move forward with this if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Why were these revs updated?
note: Also, these should not be committed and will also be overridden by operator-templating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, TBH: that seems to have come from some local automated action. I've reverted them.
| [patch."https://github.com/stackabletech/operator-rs.git"] | ||
| # stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" } | ||
| # stackable-operator = { path = "../operator-rs/crates/stackable-operator" } | ||
| stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "feat/gitsync-ssh" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: This needs to be reverted once the operator-rs PR is merged.
Description
Warning
WIP: need to re-set to operator-rs version rather than PR branch.
Related to #382.
Tested with stackabletech/operator-rs#1121.
Tip
To test:
stackablectl op in airflow=0.0.0-pr725./scripts/run-tests --skip-operator airflow --test versioningTests 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/70/ (Openshift OKD 4.20)
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker