Skip to content

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Dec 22, 2025

Description

Warning

WIP: need to re-set to operator-rs version rather than PR branch.

Related to #382.
Tested with stackabletech/operator-rs#1121.

Tip

To test:

stackablectl op in airflow=0.0.0-pr725
./scripts/run-tests --skip-operator airflow --test versioning

Tests 🟢 https://testing.stackable.tech/view/02%20Operator%20Tests%20(custom)/job/airflow-operator-it-custom/70/ (Openshift OKD 4.20)

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 marked this pull request as ready for review December 23, 2025 09:20
@adwk67 adwk67 linked an issue Dec 23, 2025 that may be closed by this pull request
@adwk67 adwk67 self-assigned this Dec 23, 2025
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Dec 23, 2025
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Progress in Stackable Engineering Dec 23, 2025
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jan 8, 2026
@sbernauer sbernauer requested a review from Techassi January 12, 2026 08:15
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 12, 2026
@adwk67 adwk67 requested a review from Techassi January 14, 2026 12:41
Copy link
Member

@Techassi Techassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also let me know if I should take a look at the documentation as well.

Also, I can review (and eventually approve) the operator-rs PR before we move forward with this if you want.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why were these revs updated?

note: Also, these should not be committed and will also be overridden by operator-templating.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, TBH: that seems to have come from some local automated action. I've reverted them.

[patch."https://github.com/stackabletech/operator-rs.git"]
# stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "main" }
# stackable-operator = { path = "../operator-rs/crates/stackable-operator" }
stackable-operator = { git = "https://github.com/stackabletech//operator-rs.git", branch = "feat/gitsync-ssh" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This needs to be reverted once the operator-rs PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

Feature Request: Airflow to support DAGs Git Sync using SSH Key

4 participants