feat: add backgroundSidebar theme property for independent configuration of the sidebar's background colour (resolves #5286) #5297
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sidebar theming Resolves GitHub issue sst#5286 by adding a new sidebarBackgroundPanel theme property that: - Allows independent theming of sidebar background separate from chat message panels - Falls back to backgroundPanel for backward compatibility (as requested by ariane-emory) - Updates core theme system with proper type definitions and resolution logic - Updates TUI sidebar component to use new theme property - Does NOT modify built-in themes - they use fallback logic automatically This enables users to theme sidebar background independently while maintaining full backward compatibility with all existing themes.
ariane-emory
changed the title
|
Yesss 🎉 Also, thinking of the existing naming conventions, do you think it should it be |
Contributor
Author
|
Sure, I can change the name if you'd like. There's also a test GH action failing presently, as you can see on this page. Gimme little longer get that done, OC somehow trounced part of my usual dev env and putting it back together might take me another hour or two. |
That's probably more of a Dax/Adam question though! ❤️ |
Rename sidebarBackgroundPanel to backgroundSidebar to allow independent theming of sidebar background color from chat message panels. This addresses GitHub issue sst#5286 where users wanted to theme the sidebar background separately from the backgroundPanel used by chat messages. Changes: - Rename ThemeColors.sidebarBackgroundPanel to backgroundSidebar - Update ThemeJson type definitions - Update theme resolution logic with fallback to backgroundPanel - Update sidebar component to use new property name - Maintain backward compatibility through optional fallback
ariane-emory
changed the title
Contributor
Author
|
Corrupted by a bad merge, will fix. |
ariane-emory
force-pushed
the
feat/sidebar-color-prop-5286
branch
2 times, most recently
from
7918faf to
79bfb34
Compare
Contributor
Author
|
Uncorrupted. |
ariane-emory
force-pushed
the
feat/sidebar-color-prop-5286
branch
from
a4cb23e to
ed52e99
Compare
ariane-emory
force-pushed
the
feat/sidebar-color-prop-5286
branch
from
dcbe925 to
ed52e99
Compare
…y/opencode into feat/sidebar-color-prop-5286
…y/opencode into feat/sidebar-color-prop-5286
ariane-emory
force-pushed
the
feat/sidebar-color-prop-5286
branch
from
57a2e93 to
1626d89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new, optional backgroundSidebar theme property that:
This enables users to theme sidebar background independently while maintaining full backward compatibility with all existing themes (both stock and custom).
Resolves #5286.