-
Notifications
You must be signed in to change notification settings - Fork 599
Bumping to Gradle9 #3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
oldergod
wants to merge
3
commits into
master
Choose a base branch
from
bquenaudon.2025-11-10.gradle9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bumping to Gradle9 #3454
+140
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bb747d to
637ab7d
Compare
oldergod
commented
Nov 10, 2025
wire-tests/build.gradle.kts
Outdated
| val test by getting { | ||
| val jvmTest by getting { | ||
| java.srcDir("src/jvmTest/proto-java") | ||
| } |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a problem
wire-tests/build.gradle.kts
Outdated
Comment on lines
253
to
256
| add("jvmJavaTestImplementation", projects.wireMoshiAdapter) | ||
| add("jvmJavaTestImplementation", libs.kotlin.reflect) | ||
| add("jvmJavaTestImplementation", libs.moshi) | ||
| add("jvmJavaTestImplementation", libs.moshiKotlin) |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another problem
637ab7d to
3535141
Compare
3b8988a to
d8b8c71
Compare
d8b8c71 to
88b49aa
Compare
303bc9c to
90ff415
Compare
90ff415 to
17481d9
Compare
Member
Author
|
Blocked by gradle/gradle-native#1126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #3413