Open
Conversation
cesar-sosa-hol
requested review from
Armaxis,
brandonjenniges,
jyotikdev and
millerjasonw
tamerbader
reviewed
Dec 18, 2025
Comment on lines
+169
to
+219
| extension ReaderStatus { | ||
| func toName() -> String { | ||
| return switch self { | ||
| case .connectingToDevice: | ||
| "CONNECTING_TO_DEVICE" | ||
| case .connectingToSquare: | ||
| "CONNECTING_TO_SQUARE" | ||
| case .readerUnavailable : | ||
| "READER_UNAVAILABLE" | ||
| case .faulty: | ||
| "FAULTY" | ||
| case .ready: | ||
| "READY" | ||
| default : | ||
| "UNKNOWN" | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension ReaderUnavailableReason { | ||
| func toName() -> String { | ||
| return switch self { | ||
| case .internalError: | ||
| "INTERNAL_ERROR" | ||
| case .bluetoothDisabled: | ||
| "BLUETOOTH_DISABLED" | ||
| case .bluetoothFailure: | ||
| "BLUETOOTH_FAILURE" | ||
| case .secureConnectionToSquareFailure: | ||
| "SECURE_CONNECTION_TO_SQUARE_FAILURE" | ||
| case .secureConnectionNetworkFailure: | ||
| "SECURE_CONNECTION_NETWORK_FAILURE" | ||
| case .blockingFirmwareUpdate: | ||
| "BLOCKING_UPDATE" | ||
| case .maxReadersConnected: | ||
| "MAX_READERS_CONNECTED" | ||
| case .notConnectedToInternet | ||
| : "NOT_CONNECTED_TO_INTERNET" | ||
| case .readerTimeout: | ||
| "READER_TIMEOUT" | ||
| case .revokedByDevice: | ||
| "REVOKED_BY_DEVICE" | ||
| case .tapToPayError: | ||
| "TAP_TO_PAY_ERROR" | ||
| case .tapToPayIsNotLinked: | ||
| "TAP_TO_PAY_IS_NOT_LINKED" | ||
| default: | ||
| "UNKNOWN" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a reason why you're writing out strings for each status and unavailable reason when both those API's have a public description property?
There was a problem hiding this comment.
Looks like this is the way it's done for all MPSDK enums so LGTM.
tamerbader
approved these changes
Dec 18, 2025
brandonjenniges
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.