Remove compiler warnings for spring-security-oauth2-authorization-server

[gisu1102]

Summary

Closes #18432

• AOT/runtime hints in the OAuth2 Authorization Server module

  • Before: Included ACCESS_DECLARED_FIELDS, which is no longer applicable in Spring Framework 7 and could trigger compiler warnings.
  • After: Removed ACCESS_DECLARED_FIELDS, keeping only the required INVOKE_DECLARED_* categories.

• Deprecated Jackson2 adapter usage

  • Before: Deprecated Jackson2 adapter types were used without explicit removal suppression.
  • After: Added @SuppressWarnings("removal") only to deprecated Jackson2 adapter classes to document intentional usage.

Testing

• ./gradlew --no-build-cache clean :spring-security-oauth2-authorization-server:check

Notes

Other module warnings are unchanged and outside this module’s scope.

[rwinch]

Thanks for the PR! I've responded with a few comments. Please keep in mind that there are a few examples of me wanting to understand why the deprecated fields in MemberCategory were not migrated according to the Javadocs, but this is a general question and should be considered throughout the whole pull request.

[rwinch]

This needs to continue to register the jackson 2 modules for passivity. You can extract it into a separate method and add a suppression to it.

[gisu1102]

Agreed. Jackson 2 module registration is still required for passivity when Jackson 2
is present on the classpath.

I will keep the Jackson 2 registrations, extract them into a dedicated helper method,
and scope @SuppressWarnings("removal") to that method only so the intent is explicit
while preserving the existing behavior.

Jackson 3 module registration will remain unchanged.
Thank you.

[rwinch]

This and the similar changes don't seem to be a one to one change from deprecation to replacement. For example, I'd expect this change to be as shown in this suggestion since the deprecation for DECLARED_CLASSES states it is deprecated with no replacement since registerType registers the class.

Suggested change

	hints.reflection()
	.registerType(Collections.class, MemberCategory.INVOKE_DECLARED_CONSTRUCTORS,
	MemberCategory.INVOKE_DECLARED_METHODS);
	hints.reflection().registerType(Collections.class);

Can you help me understand why these changes do not appear to be a one to one replacement for the deprecations?

[gisu1102]

Thanks for the clarification.

You're right — my change removed MemberCategory.DECLARED_CLASSES but didn’t make it explicit that the type itself is still being registered.
Since DECLARED_CLASSES is deprecated with no replacement (because registerType already registers the class), I’ll add an explicit
hints.reflection().registerType(T.class) alongside the existing INVOKE_* categories. This preserves the original “type registration”
intent while keeping the reflective invocation hints where needed.

[rwinch]

Can you help me understand why MemberCategory.DECLARED_FIELDS wasn't migrated to MemberCategory.INVOKE_DECLARED_FIELDS as documented within the Javadoc?

[gisu1102]

Thank you for pointing this out.

You’re right — MemberCategory.DECLARED_FIELDS should be migrated to MemberCategory.ACCESS_DECLARED_FIELDS as documented in the Javadoc.

In my earlier change, I removed DECLARED_FIELDS without explicitly replacing it with ACCESS_DECLARED_FIELDS, which made the migration look incomplete and not 1:1.

I’ve updated the code so that:

• All previous DECLARED_FIELDS usages are now migrated to
  ACCESS_DECLARED_FIELDS.
• INVOKE_DECLARED_CONSTRUCTORS / INVOKE_DECLARED_METHODS are kept only where
  reflective invocation was already required.

This preserves the original intent of field access while aligning with the documented replacement in Spring Framework 7.

[gisu1102]

@rwinch
Thanks for the review!

I’ve addressed all of the requested changes:

• Restored Jackson2 module registration for passivity
• Migrated DECLARED_CLASSES and DECLARED_FIELDS 1:1 according to the Spring Framework 7 Javadocs

Could you please take another look when you have a moment?

[rwinch]

Thank you for the updates! This will be merged once the build passes

[gisu1102]

Thank you for the updates! This will be merged once the build passes

Thanks for the review and the helpful comments.
I’ll check the build and formatting issues and follow up with an update shortly.