Skip to content

Conversation

@ronodhirSoumik
Copy link
Contributor

@ronodhirSoumik ronodhirSoumik commented Jan 13, 2026

Fixes #17815

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 13, 2026
ronodhirSoumik and others added 4 commits January 21, 2026 13:53
Fixes spring-projects#17815

Signed-off-by: Soumik Sarker <ronodhirsoumik@gmail.com>
Signed-off-by: Soumik Sarker <ronodhirsoumik@gmail.com>
Signed-off-by: Soumik Sarker <ronodhirsoumik@gmail.com>
@rwinch rwinch force-pushed the improv/removed-nullUnmarked-from-observability-web-classes branch from cea75b8 to 987339c Compare January 21, 2026 19:58
@rwinch
Copy link
Member

rwinch commented Jan 21, 2026

Thanks for the PR @ronodhirSoumik Unfortunately, the build fails.

/home/runner/work/spring-security/spring-security/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java:323: error: [NullAway] dereferenced expression this.reference.get() is @Nullable
				this.reference.get().error(ex);
				                    ^
    (see http://t.uber.com/nullaway )
/home/runner/work/spring-security/spring-security/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java:328: error: [NullAway] dereferenced expression this.reference.get() is @Nullable
				this.reference.get().stop();
				                    ^
    (see http://t.uber.com/nullaway )

I've rebased it and fixed the errors and this will be merged once the build passes.

@rwinch rwinch enabled auto-merge (rebase) January 21, 2026 19:58
@rwinch rwinch self-assigned this Jan 21, 2026
@rwinch rwinch added in: build An issue in the build type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 21, 2026
@rwinch rwinch added this to the 7.1.0-M2 milestone Jan 21, 2026
@rwinch rwinch merged commit 9f8ac34 into spring-projects:main Jan 21, 2026
6 checks passed
@rwinch rwinch changed the title Improv/removed null unmarked from observability web classes Remove @NullUnmarked Jan 21, 2026
@ronodhirSoumik
Copy link
Contributor Author

Thanks for the PR @ronodhirSoumik Unfortunately, the build fails.

/home/runner/work/spring-security/spring-security/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java:323: error: [NullAway] dereferenced expression this.reference.get() is @Nullable
				this.reference.get().error(ex);
				                    ^
    (see http://t.uber.com/nullaway )
/home/runner/work/spring-security/spring-security/web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java:328: error: [NullAway] dereferenced expression this.reference.get() is @Nullable
				this.reference.get().stop();
				                    ^
    (see http://t.uber.com/nullaway )

I've rebased it and fixed the errors and this will be merged once the build passes.

sry I missed the build issue - thanks for pointing it out and for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: build An issue in the build type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove @NullUnmarked from observability web classes

3 participants