GH-3062: Fix KafkaBinderMetrics for resource leaks
#3064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: spring-cloud#3062 The `KafkaBinderMetrics` creates `KafkaConsumer` instances and schedule the fix rate task for them, but never closes them even when the `scheduler` is shut downed * Implement a `Lifecycle` contract in the `KafkaBinderMetrics` and call `close()` from the `stop()` to satisfy CRaC resource management expectations. * Also close all the `KafkaConsumer` instances from the `metadataConsumers` **Cherry-pick to `4.1.x`**
Member
Author
|
Do not merge yet. |
When CRaC checkpoint is requested, the binder contexts must be stopped as well, which includes all their managed beans, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3062
The
KafkaBinderMetricscreatesKafkaConsumerinstances and schedule the fix rate task for them, but never closes them even when thescheduleris shut downedLifecyclecontract in theKafkaBinderMetricsand callclose()from thestop()to satisfy CRaC resource management expectations.KafkaConsumerinstances from themetadataConsumersCherry-pick to
4.1.x