Skip to content

Remove commons-beanutils usage #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ryanjbaxter merged 5 commits into from
Jan 21, 2026
Merged

Remove commons-beanutils usage #2408

ryanjbaxter merged 5 commits into from
Jan 21, 2026

Conversation

@marcingrzejszczak
Copy link
Contributor

@marcingrzejszczak marcingrzejszczak commented Jan 19, 2026

fixes #2129

@ryanjbaxter
Copy link
Contributor

ryanjbaxter commented Jan 20, 2026

This would be a breaking change, no? I get its an outdated library, but someone could be depending on it

@marcingrzejszczak
Copy link
Contributor Author

marcingrzejszczak commented Jan 20, 2026

Yeah... that's true. We could leave the dependency but not use it so people can safely exclude it. WDYT?

@ryanjbaxter
Copy link
Contributor

ryanjbaxter commented Jan 20, 2026

Sounds good to me

@marcingrzejszczak
Copy link
Contributor Author

marcingrzejszczak commented Jan 21, 2026

Fixed

@ryanjbaxter
Copy link
Contributor

ryanjbaxter commented Jan 21, 2026

Should we add a comment to the POM indicating the dependency is not longer used but kept for backward compatibility purposes?

Also it looks like the github actions config was not building PRs against the 4.3.x branch. I just updated the config. The 4.3.x branch is for me and on Jenkins after this change 0976c63
I know this is separate from this PR, but I was perplexed as to why the build was passing.

@ryanjbaxter
Copy link
Contributor

ryanjbaxter commented Jan 21, 2026

There we go there is the failure 😂

@marcingrzejszczak
Copy link
Contributor Author

marcingrzejszczak commented Jan 21, 2026

Believe it or not but the build passes on my machine... I'll look into this

@ryanjbaxter
Copy link
Contributor

ryanjbaxter commented Jan 21, 2026

Oh I believe it 🤦‍♂️

@marcingrzejszczak
Remove commons-beanutils usage
b977c7a 
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
@marcingrzejszczak
Bring back commons-beanutils - don't want to break compatibility
0987814 
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
@marcingrzejszczak
Added note about why we leave commons-beanutils
3a528fc 
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
@marcingrzejszczak
fix: potential fix for CI problems
730e29f 
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
@marcingrzejszczak
fix: potential fix for CI problems
bd1d4a4 
Signed-off-by: Marcin Grzejszczak <marcin@grzejszczak.pl>
@marcingrzejszczak
Copy link
Contributor Author

marcingrzejszczak commented Jan 21, 2026

Hurray, the build is green

@ryanjbaxter ryanjbaxter linked an issue Jan 21, 2026 that may be closed by this pull request
Get rid of commons-beanutils #2129
Open
@ryanjbaxter ryanjbaxter merged commit 226c205 into spring-cloud:4.3.x Jan 21, 2026
4 checks passed
@marcingrzejszczak marcingrzejszczak deleted the issue/gh-2129 branch January 21, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Get rid of commons-beanutils

3 participants

@marcingrzejszczak @ryanjbaxter @spring-cloud-issues