General code cleanup and many minor fixes#50
Open
gitpushoriginmaster wants to merge 1 commit intospotify:mainfrom
Open
General code cleanup and many minor fixes#50gitpushoriginmaster wants to merge 1 commit intospotify:mainfrom
gitpushoriginmaster wants to merge 1 commit intospotify:mainfrom
Conversation
Comment on lines
-207
to
-217
| x_contours = tfkl.Conv2D( | ||
| n_filters_contour, | ||
| (5, 5), | ||
| padding="same", | ||
| kernel_initializer=_initializer(), | ||
| kernel_constraint=_kernel_constraint(), | ||
| )(x) | ||
|
|
||
| x_contours = tfkl.BatchNormalization()(x_contours) | ||
| x_contours = tfkl.ReLU()(x_contours) | ||
|
|
Author
There was a problem hiding this comment.
Please note I'm including this cleanup that was discussed in #23, but since it creates a layer and overwrites it, I think that these lines are just computationally meaningless and have no effect on the output, but should maybe stay for 'when it is the time to fix it'.
If you'd like to leave this implementation as it is, I'll re-add this code as it was and leave references for this bug as a comment in the code.
gitpushoriginmaster
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using basic-pitch I encountered a few cases of dead code, redundant calculations, and unclear try-except blocks.
This PR is a bunch of many single-line changes. I hope my attempt to fix some of these issues is welcome.