-
Notifications
You must be signed in to change notification settings - Fork 127
Feature/postgresql logical db controller #1691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/postgresql logical db controller #1691
Conversation
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
9fc0e2f to
f952cc6
Compare
5ece4ee to
32e546e
Compare
32e546e to
91c8825
Compare
api/v4/database_types.go
Outdated
| ) | ||
|
|
||
| // DatabaseSpec defines the desired state of Database. | ||
| // +kubebuilder:validation:XValidation:rule="!has(oldSelf.clusterRef) || self.clusterRef == oldSelf.clusterRef",message="clusterRef is immutable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: !has(oldSelf.clusterRef) is always true, as ClusterRef is Required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is not when it is first deployment not update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"A rule that contains an expression referencing the identifier oldSelf is implicitly considered a transition rule. [...] Transition rules never apply to create operations." Source: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#transition-rules
Based on that, this rule is not running on the first deployment, as there is no oldSelf that could be used at all.
|
LGTM! |
Description
Adds the database CRD and validation
Key Changes
Highlight the updates in specific files
Testing and Verification
Added few validation yaml files to examples
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist