Open
Conversation
…ontaining valid SAN and change in Go1.17 which require SAN
sonalpatel38-nhs
approved these changes
Sep 5, 2022
| labelsKey: "a", | ||
| envRegexKey: "^foo", | ||
| }, | ||
| ContainerID: "containeriid", |
There was a problem hiding this comment.
Is this a typo? Should it be containerid?
Author
There was a problem hiding this comment.
It does look like a typo but it is copied from elsewhere in this file (see lines 348 & 452). It actually doesn't matter if it is a typo in this context as it is just test data that isn't used for anything meaningful
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduce a new splunk-format named "hec" which fixes issue #48
This allows containers to output logs in the JSON format as expected by the Splunk HEC endpoint (https://docs.splunk.com/Documentation/Splunk/9.0.0/Data/FormateventsforHTTPEventCollector) and the logging driver will parse these correctly. Applications running in containers will be able to control which index, source, sourcetype etc. log events should be set to within Splunk.
Also replaces the CircleCI integration for testing with Github Actions. Unfortunately this has not fixed issue #45 and functional tests still intermittently fail. A fully successful run has been completed with the current changes.
Minor changes; uplift Go version to 1.19.0 and switch to go modules instead of dep (which has been deprecated since 2020). Uplift Python version used for functional tests to 3.8 (needed due to updated Python dependencies), this also required a rebuild of the python protobuf file.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.