-
Notifications
You must be signed in to change notification settings - Fork 267
Remove Externally Hosted Images #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Externally Hosted Images #583
Conversation
…a self-hosted image.
…lf-hosted images.
|
I'm finished with this. I'll need a few look-overs, likely, so again, reviews would be appreciated. |
…ecessary external links from maintainer-meeting files.
|
Oh, thank you! |
ArtisticRoomba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things I saw
In general I'd say it's fine to not remove images hosted on hedgedoc because that is something we host.
| ``` | ||
| Notice: This meeting was recorded: | ||
|
|
||
| {% embed youtube id="4B80_pRZ_Mc" loading="lazy" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did you mean to remove this? This link is still valid
I will keep that in note. Thank you. |
ArtisticRoomba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. Thanks for the work, if I start seeing blank media everywhere I'll just revert this and we can go for a second round of fixes.
Just let me know if such happens! |
This pull request addresses #566.
Over 50 files contain Imgur links or other externally hosted images. This pull request removes them and replaces each with a self-hosted file.
This may take some time to complete, so this pull request will remain a draft until all links are replaced. If there are any mistakes made, please comment on them.