Add ShardPrefixOverride to support custom shard naming#1005
Open
raviiitb wants to merge 1 commit intosourcegraph:mainfrom
Open
Add ShardPrefixOverride to support custom shard naming#1005raviiitb wants to merge 1 commit intosourcegraph:mainfrom
raviiitb wants to merge 1 commit intosourcegraph:mainfrom
Conversation
Author
|
@keegancsmith, could you please review this PR? |
Author
|
@keegancsmith Just a gentle ping, if you get a chance to review this MR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
ShardPrefixOverrideinOptionsto support a custom prefix for shard names. At GitLab, currently, we send the repositoryIDin the fieldRepositoryDescription.Name. Now we want to supportrepo:filtering. For that, we need to send the repository name for the fieldRepositoryDescription.Name. But we want to keep the prefix name asIDbecause it will be a huge effort to change the prefix now. Our suggestion is to add a new option fieldShardPrefixOverride, which we can use to send theID.Also added the command-line option
-shard_prefix_overridefor the same.