fix(web): use Link for Go to Definition to allow opening in new tab (#793) #799
+51
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR updates the "Go to Definition" button in the symbol hover tooltip to use a Nextjs Link component when a definition is found
Changes:
Uses getBrowsePath to correctly generate the destination URL
Conditionally renders a for single definitions, allowing users to Cmd Click / Middle Click to open the file in a new tab
Notes:
I chose not to update the "Find References" button in this PR. Since that action primarily toggles the side panel state rather than navigating to a distinct resource, it feels more appropriate to keep it as a button for now to ensure stable behaviour.
Fixes #793
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.