Skip to content

Sort members by name#964

Open
agross wants to merge 2 commits intosolidtime-io:mainfrom
GROSSWEBER:sort-members
Open

Sort members by name#964
agross wants to merge 2 commits intosolidtime-io:mainfrom
GROSSWEBER:sort-members

Conversation

@agross
Copy link
Contributor

@agross agross commented Nov 6, 2025

What does this PR do?

Comparable to #963: We have many entries on the non-admin members page that are currently unsorted and hard to manage. This PR adds sorting by members' user names.

I don't know if there is a more effective way, given that users have been eagerly loaded before this PR. I'm not sure if users are loaded twice now: once via eager loading with with, and now a second time by now joining them to members.

I tried adding orderBy to the with clause to cause the member list to be sorted by user name. But that will only sort the eagerly loaded user list without causing the desired effect.

Checklist (DO NOT REMOVE)

@agross
Copy link
Contributor Author

agross commented Feb 16, 2026

It would have been great to see this in 0.11, but it seems I need to run a custom image for the foreseeable future.

@Onatcer
Copy link
Contributor

Onatcer commented Feb 17, 2026

@agross sorry i forgot those are still open. to be honest I'm not a big fan of sorting them by name in the API by default. Primarily because the client, tags and reports endpoints all sort by created_at and making projects and members sorted by name by default would just make it inconsistent.

Do you need them sorted in the API or do you only care about the UI? Because v0.11.1 adds UI sorting for projects where the sorting persists in the localStorage. I'd much rather add those sorting options to the members table in the UI for now than mixing the API defaults here. Ultimately we need sorting attributes on all of them anyway.

for reference this is the project table since v0.11
image

@agross
Copy link
Contributor Author

agross commented Feb 17, 2026

Hello, sorting by created date does not make sense to us on the UI. Consider a company with more than a handful of clients, projects, tags etc. How relevant is sorting by created date? For us the answer is: never.

I have a patched v0.11.1 running and there is no way to sort anything on the UI, except for projects. I don't use about sorting via API, but I need to cater for people working the Solidtime UI.

With the current state of things it seems that #963 can be closed/abandoned. This can be abandoned when the Members list has caught up UI-wise.

I don't know if the APIs also influence sorting things in the PDF reports. As a consumer of those reports (i.e. our clients) I would expect things to be sorted by name, e.g. projects were time was spent on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants