Skip to content

Conversation

@katywings
Copy link
Contributor

@katywings katywings commented Dec 21, 2025

Changes

  1. Implements new css fixture test for virtual modules
  2. Fixes dev css crawling for virtual modules, by using built-in method from vite to fetch module deps
  3. Converts \0virtual:module.css to /@id/__x00__virtual:module.css in manifest, to fix dynamic import of virtual modules
  4. Patches data-vite-dev-id attributes for style tags of virtual modules

Fixes tested with

  • css fixture and nitro 2
  • css fixture and nitro 3.0.1-alpha.1
  • solidbase (nitro 2)
  • nitropage (nitro 3.0.1-alpha.1)

Other information

Before change 2+3: https://github.com/user-attachments/assets/630e827b-5241-403f-9a70-5d4ccbb0db90
After: https://github.com/user-attachments/assets/7d3af2e8-5211-4f05-b8de-9f14ef153549

Before change 4: https://github.com/user-attachments/assets/e8e59e0b-800f-42ab-b8df-f452ea8d0de7
After: https://github.com/user-attachments/assets/a19627dd-232e-41b1-b72f-f54714b5df42

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2025

🦋 Changeset detected

Latest commit: d1a23f5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@katywings katywings self-assigned this Dec 21, 2025
@katywings katywings added bug Something isn't working 2.x targeting SolidStart 2.x versions labels Dec 21, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 21, 2025

Open in StackBlitz

npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2039
npm i https://pkg.pr.new/solidjs/solid-start/@solidjs/vite-plugin-nitro-2@2039

commit: d1a23f5

@netlify
Copy link

netlify bot commented Dec 21, 2025

Deploy Preview for solid-start-landing-page ready!

Name Link
🔨 Latest commit d1a23f5
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/694856ed012fe20008a5c6bc
😎 Deploy Preview https://deploy-preview-2039--solid-start-landing-page.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@katywings katywings marked this pull request as ready for review December 21, 2025 20:23
@katywings katywings changed the title WIP: fix: server render virtual css fix: server render virtual css Dec 21, 2025
@katywings katywings changed the title fix: server render virtual css fix: collect virtual module CSS in vite dev Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.x targeting SolidStart 2.x versions bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants