Skip to content

Conversation

@m-bert
Copy link
Contributor

@m-bert m-bert commented Dec 23, 2025

Description

This PR updates quick start guide in our docs.

Test plan

Read docs (and follow the implementation 🤭) 🤓

@m-bert m-bert added the Documentation Documentation change/enhancement label Jan 9, 2026
@m-bert m-bert requested a review from akwasniewski January 9, 2026 15:11
<Step title="Step 4">
<div>And add it to the ball's styles:</div>
<div>
Now, define the <code>Pan</code> gesture logic:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to explain how this works here, rather than at the end.

Suggested change
Now, define the <code>Pan</code> gesture logic:
Now, define the <code>Pan</code> gesture logic:
</br>
Note the start shared value. We need it to store the position of the ball at the moment we grab it to be able to correctly position it later, as we only have access to translation relative to the starting point of the gesture.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c82771e - let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe "We need the start SharedValue to...."?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like these 2 code blocks beside 😞 That of course doesn't mean that we shouldn't do it, but in that step we have only one SharedValue anyway, so I'm not sure if this is necessary (cc @j-piasecki)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also update the example to use changeX/Y instead of translation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation change/enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants