-
-
Notifications
You must be signed in to change notification settings - Fork 1k
[docs] Update quick start #3895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: @mbert/docs-detector
Are you sure you want to change the base?
Conversation
| <Step title="Step 4"> | ||
| <div>And add it to the ball's styles:</div> | ||
| <div> | ||
| Now, define the <code>Pan</code> gesture logic: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is better to explain how this works here, rather than at the end.
| Now, define the <code>Pan</code> gesture logic: | |
| Now, define the <code>Pan</code> gesture logic: | |
| </br> | |
| Note the start shared value. We need it to store the position of the ball at the moment we grab it to be able to correctly position it later, as we only have access to translation relative to the starting point of the gesture. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c82771e - let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "We need the start SharedValue to...."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like these 2 code blocks beside 😞 That of course doesn't mean that we shouldn't do it, but in that step we have only one SharedValue anyway, so I'm not sure if this is necessary (cc @j-piasecki)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also update the example to use changeX/Y instead of translation.
Description
This PR updates quick start guide in our docs.
Test plan
Read docs (and follow the implementation 🤭) 🤓