-
-
Notifications
You must be signed in to change notification settings - Fork 1k
V3 examples #3857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
V3 examples #3857
Conversation
m-bert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, here are mu findings 🫨 I'm not sure if any of them will be fixed when we merge next, but hopefully there are a few like this 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just leave a comment - it seems that it doesn't work, but I'm not sure if this is because next has not been merged yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not for this PR, as it only changed colors, but it breaks when type is changed to back:
Description
Made a new PR, as it is easier than attempt to merge the old one with next.
This PR adds a toggle in the example app to switch between Legacy and V3 api examples. In the new api section I added split into few sections. Most of them are rewritten old V2 examples with more consistent styling.
I also added a Feedback component to showcase features console free.
The new examples are:
Test plan
See if the examples in new api section from common-example work