Skip to content

fix(engine.io): emit initial_headers and headers events in uServer #5460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erdinccurebal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(engine.io): emit initial_headers and headers events in uServer #5460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/engine.io/lib/userver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,23 @@ export class uServer extends BaseServer {
}
}

// emit headers events for WebSocket upgrades
const additionalHeaders = {};
const isInitialRequest = !id;

if (isInitialRequest) {
this.emit("initial_headers", additionalHeaders, req);
}

this.emit("headers", additionalHeaders, req);

// calling writeStatus() triggers the flushing of any header added in a middleware
req.res.writeStatus("101 Switching Protocols");

Object.keys(additionalHeaders).forEach((key) => {
req.res.writeHeader(key, additionalHeaders[key]);
});

res.upgrade(
{
transport,
Expand Down
10 changes: 2 additions & 8 deletions packages/engine.io/test/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3598,10 +3598,7 @@ describe("server", () => {
});

it("should emit a 'initial_headers' event (websocket)", function (done) {
if (
process.env.EIO_WS_ENGINE === "eiows" ||
process.env.EIO_WS_ENGINE === "uws"
) {
if (process.env.EIO_WS_ENGINE === "eiows") {
return this.skip();
}
const partialDone = createPartialDone(done, 2);
Expand Down Expand Up @@ -3644,10 +3641,7 @@ describe("server", () => {
});

it("should emit several 'headers' events per connection", function (done) {
if (
process.env.EIO_WS_ENGINE === "eiows" ||
process.env.EIO_WS_ENGINE === "uws"
) {
if (process.env.EIO_WS_ENGINE === "eiows") {
return this.skip();
}
const partialDone = createPartialDone(done, 4);
Expand Down