Open
Conversation
PatrickAlphaC
suggested changes
Aug 1, 2022
PatrickAlphaC
left a comment
PatrickAlphaC
left a comment
There was a problem hiding this comment.
Could we add some tests? It'll be a lot easier to see what these are trying to do with tests.
And maybe we rename the folder to "defi-automation" I feel like "keepers-minimal" doesn't really do it justice, what do you think?
| 3. Run tests | ||
|
|
||
| ```shell | ||
| yarn test |
There was a problem hiding this comment.
Looks like there are no tests right now?
Contributor
Author
There was a problem hiding this comment.
Sure thing, will add tests soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This project aims to show minimal examples of using Chainlink Keepers to automate some of the contracts from the defi-minimal repository.
Please do check the README file carefully. Thanks