Replace get_class() calls with ::class keyword#3423
Open
QDenka wants to merge 1 commit intoslimphp:5.xfrom
Open
Replace get_class() calls with ::class keyword#3423QDenka wants to merge 1 commit intoslimphp:5.xfrom
QDenka wants to merge 1 commit intoslimphp:5.xfrom
Conversation
Since Slim 5.x requires PHP 8.2+, we can use the $object::class syntax (available since PHP 8.0) instead of get_class($object). This is more concise, consistent with static ::class usage, and avoids a function call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Slim 5.x requires PHP 8.2+, we can use the
$object::classsyntax (available since PHP 8.0) instead ofget_class($object).Changes
Replaced
get_class($exception)with$exception::classin 4 exception middleware files:HtmlExceptionMiddlewareJsonExceptionMiddlewarePlainTextExceptionMiddlewareXmlExceptionMiddlewareWhy
ClassName::classusageget_class()without arguments is deprecated since PHP 8.3