[Bugfix] Ensure the org switch flow works with redirect#327
Merged
Conversation
Deploying website-react-storybook with
|
| Latest commit: |
95e7418
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1b774df8.website-react-storybook.pages.dev |
| Branch Preview URL: | https://sid-fix-org-switching-with-r.website-react-storybook.pages.dev |
jake-slashid
approved these changes
Apr 23, 2025
kaspermroz
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the org switching flow involves a redirect (in case of SSO via OIDC/SAML), the SDK would not finish the flow properly as after loading the page again it loses any in-memory context.
Specifically, we observed this sequence of events in the SlashID Console:
Then the SDK does the following:
To fix this, this PR adds a flag that uses
sessionStorageto survive the redirect and tell the SDK to store the new token under the target org namespace.Checklist
changesetif my change affects the published packages